Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the class from
focus:ring-0
tofocus:ring
to improve keyboard navigation and accessibility in theTab
component.Another class idea I had was
focus:ring-1 rounded-t
, which would have slightly softer featuresRelated issue(s)
#305
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
How has this been tested?
Visual UI/UX test using storybook
npm run storybook
Screenshots (if appropriate):
MacBook Pro Sonoma 14.2.1
Chrome Version 123.0.6312.87 (Official Build) (arm64)
The PR fulfils these requirements:
main
branch