Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tab focus #1009

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: tab focus #1009

merged 1 commit into from
Apr 12, 2024

Conversation

adnjoo
Copy link
Contributor

@adnjoo adnjoo commented Apr 3, 2024

Description

Changed the class from focus:ring-0 to focus:ring to improve keyboard navigation and accessibility in the Tab component.

Another class idea I had was focus:ring-1 rounded-t, which would have slightly softer features

Related issue(s)

#305

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Visual UI/UX test using storybook npm run storybook

Screenshots (if appropriate):

MacBook Pro Sonoma 14.2.1
Chrome Version 123.0.6312.87 (Official Build) (arm64)

Screenshot 2024-04-02 at 10 21 25 PM

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 5:23am

@severinlandolt
Copy link
Member

Thanks, will check this out this week!

@severinlandolt severinlandolt changed the title feat: focus tab fix: tab focus Apr 12, 2024
@severinlandolt severinlandolt changed the base branch from main to beta-tabfixes April 12, 2024 08:10
@severinlandolt severinlandolt merged commit bd571b5 into tremorlabs:beta-tabfixes Apr 12, 2024
32 checks passed
Copy link

🎉 This PR is included in version 3.15.1-beta-tabfixes.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

severinlandolt added a commit that referenced this pull request Apr 12, 2024
* fix: tab colors

* edit class (#1009)

* fix: ring focus visible

* fix: update color classNames

---------

Co-authored-by: Andrew Njoo <[email protected]>
@adnjoo adnjoo deleted the feat/focus-tab branch April 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants